| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220614142638.rkvjemu5r7d4a6td@wittgenstein>
Date: Tue, 14 Jun 2022 16:26:38 +0200
From: Christian Brauner <brauner@...nel.org>
To: Tejun Heo <tj@...nel.org>
Cc: Mukesh Ojha <quic_mojha@...cinc.com>, paulmck@...nel.org,
lkml <linux-kernel@...r.kernel.org>, cgroups@...r.kernel.org,
hannes@...xchg.org, shisiyuan <shisiyuan19870131@...il.com>,
Li Zefan <lizefan@...wei.com>,
Michal Koutný <mkoutny@...e.com>
Subject: Re: [PATCH cgroup/for-5.19-fixes] cgroup: Use separate src/dst nodes
when preloading css_sets for migration
On Mon, Jun 13, 2022 at 12:19:50PM -1000, Tejun Heo wrote:
> Each cset (css_set) is pinned by its tasks. When we're moving tasks around
> across csets for a migration, we need to hold the source and destination
> csets to ensure that they don't go away while we're moving tasks about. This
> is done by linking cset->mg_preload_node on either the
> mgctx->preloaded_dst_csets or mgctx->preloaded_dst_csets list. Using the
Nit: This probably wants to be
"mgctx->preloaded_src_csets or mgctx->preloaded_dst_csets lists"
it currentl has "mgctx->preloaded_dst_csets" twice. :)
> same cset->mg_preload_node for both the src and dst lists was deemed okay as
> a cset can't be both the source and destination at the same time.
>
> Unfortunately, this overloading becomes problematic when multiple tasks are
> involved in a migration and some of them are identity noop migrations while
> others are actually moving across cgroups. For example, this can happen with
> the following sequence on cgroup1:
>
> #1> mkdir -p /sys/fs/cgroup/misc/a/b
> #2> echo $$ > /sys/fs/cgroup/misc/a/cgroup.procs
> #3> RUN_A_COMMAND_WHICH_CREATES_MULTIPLE_THREADS &
> #4> PID=$!
> #5> echo $PID > /sys/fs/cgroup/misc/a/b/tasks
> #6> echo $PID > /sys/fs/cgroup/misc/a/cgroup.procs
>
> #5 moves the group leader thread into a/b and then #6 moves all threads of
> the process including the group leader back into a. In this final migration,
> non-leader threads would be doing identity migration while the group leader
> is doing an actual one.
>
> After #3, let's say the whole process was in cset A, and that after #4, the
> leader moves to cset B. Then, during #6, the following happens:
>
> 1. cgroup_migrate_add_src() is called on B for the leader.
>
> 2. cgroup_migrate_add_src() is called on A for the other threads.
>
> 3. cgroup_migrate_prepare_dst() is called. It scans the src list.
>
> 3. It notices that B wants to migrate to A, so it tries to A to the dst
> list but realizes that its ->mg_preload_node is already busy.
>
> 4. and then it notices A wants to migrate to A as it's an identity
> migration, it culls it by list_del_init()'ing its ->mg_preload_node and
> putting references accordingly.
>
> 5. The rest of migration takes place with B on the src list but nothing on
> the dst list.
>
> This means that A isn't held while migration is in progress. If all tasks
> leave A before the migration finishes and the incoming task pins it, the
> cset will be destroyed leading to use-after-free.
>
> This is caused by overloading cset->mg_preload_node for both src and dst
> preload lists. We wanted to exclude the cset from the src list but ended up
> inadvertently excluding it from the dst list too.
>
> This patch fixes the issue by separating out cset->mg_preload_node into
> ->mg_src_preload_node and ->mg_dst_preload_node, so that the src and dst
> preloadings don't interfere with each other.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Mukesh Ojha <quic_mojha@...cinc.com>
> Reported-by: shisiyuan <shisiyuan19870131@...il.com>
> Link: http://lkml.kernel.org/r/1654187688-27411-1-git-send-email-shisiyuan@xiaomi.com
> Link: https://www.spinics.net/lists/cgroups/msg33313.html
> Fixes: f817de98513d ("cgroup: prepare migration path for unified hierarchy")
> Cc: stable@...r.kernel.org # v3.16+
> ---
> Hello,
>
> Shisiyuan and Mukesh, can you guys please confirm that this fixes the
> problem you're seeing? This is a different approach from Shisiyuan's patch
> which most likely would work too but this is a bit more straightforward.
>
> Thanks.
>
> include/linux/cgroup-defs.h | 3 ++-
> kernel/cgroup/cgroup.c | 37 +++++++++++++++++++++++--------------
> 2 files changed, 25 insertions(+), 15 deletions(-)
>
> diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
> index 1bfcfb1af3524..d4427d0a0e187 100644
> --- a/include/linux/cgroup-defs.h
> +++ b/include/linux/cgroup-defs.h
> @@ -264,7 +264,8 @@ struct css_set {
> * List of csets participating in the on-going migration either as
> * source or destination. Protected by cgroup_mutex.
> */
> - struct list_head mg_preload_node;
> + struct list_head mg_src_preload_node;
> + struct list_head mg_dst_preload_node;
> struct list_head mg_node;
>
> /*
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 1779ccddb734d..13c8e91d78620 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -765,7 +765,8 @@ struct css_set init_css_set = {
> .task_iters = LIST_HEAD_INIT(init_css_set.task_iters),
> .threaded_csets = LIST_HEAD_INIT(init_css_set.threaded_csets),
> .cgrp_links = LIST_HEAD_INIT(init_css_set.cgrp_links),
> - .mg_preload_node = LIST_HEAD_INIT(init_css_set.mg_preload_node),
> + .mg_src_preload_node = LIST_HEAD_INIT(init_css_set.mg_src_preload_node),
> + .mg_dst_preload_node = LIST_HEAD_INIT(init_css_set.mg_dst_preload_node),
> .mg_node = LIST_HEAD_INIT(init_css_set.mg_node),
>
> /*
> @@ -1240,7 +1241,8 @@ static struct css_set *find_css_set(struct css_set *old_cset,
> INIT_LIST_HEAD(&cset->threaded_csets);
> INIT_HLIST_NODE(&cset->hlist);
> INIT_LIST_HEAD(&cset->cgrp_links);
> - INIT_LIST_HEAD(&cset->mg_preload_node);
> + INIT_LIST_HEAD(&cset->mg_src_preload_node);
> + INIT_LIST_HEAD(&cset->mg_dst_preload_node);
> INIT_LIST_HEAD(&cset->mg_node);
>
> /* Copy the set of subsystem state objects generated in
> @@ -2597,21 +2599,27 @@ int cgroup_migrate_vet_dst(struct cgroup *dst_cgrp)
> */
> void cgroup_migrate_finish(struct cgroup_mgctx *mgctx)
> {
> - LIST_HEAD(preloaded);
> struct css_set *cset, *tmp_cset;
>
> lockdep_assert_held(&cgroup_mutex);
>
> spin_lock_irq(&css_set_lock);
>
> - list_splice_tail_init(&mgctx->preloaded_src_csets, &preloaded);
> - list_splice_tail_init(&mgctx->preloaded_dst_csets, &preloaded);
> + list_for_each_entry_safe(cset, tmp_cset, &mgctx->preloaded_src_csets,
> + mg_src_preload_node) {
> + cset->mg_src_cgrp = NULL;
> + cset->mg_dst_cgrp = NULL;
> + cset->mg_dst_cset = NULL;
> + list_del_init(&cset->mg_src_preload_node);
> + put_css_set_locked(cset);
> + }
>
> - list_for_each_entry_safe(cset, tmp_cset, &preloaded, mg_preload_node) {
> + list_for_each_entry_safe(cset, tmp_cset, &mgctx->preloaded_dst_csets,
> + mg_dst_preload_node) {
> cset->mg_src_cgrp = NULL;
> cset->mg_dst_cgrp = NULL;
> cset->mg_dst_cset = NULL;
> - list_del_init(&cset->mg_preload_node);
> + list_del_init(&cset->mg_dst_preload_node);
> put_css_set_locked(cset);
> }
>
> @@ -2651,7 +2659,7 @@ void cgroup_migrate_add_src(struct css_set *src_cset,
> if (src_cset->dead)
> return;
>
> - if (!list_empty(&src_cset->mg_preload_node))
> + if (!list_empty(&src_cset->mg_src_preload_node))
> return;
>
> src_cgrp = cset_cgroup_from_root(src_cset, dst_cgrp->root);
> @@ -2664,7 +2672,7 @@ void cgroup_migrate_add_src(struct css_set *src_cset,
> src_cset->mg_src_cgrp = src_cgrp;
> src_cset->mg_dst_cgrp = dst_cgrp;
> get_css_set(src_cset);
> - list_add_tail(&src_cset->mg_preload_node, &mgctx->preloaded_src_csets);
> + list_add_tail(&src_cset->mg_src_preload_node, &mgctx->preloaded_src_csets);
> }
>
> /**
> @@ -2689,7 +2697,7 @@ int cgroup_migrate_prepare_dst(struct cgroup_mgctx *mgctx)
>
> /* look up the dst cset for each src cset and link it to src */
> list_for_each_entry_safe(src_cset, tmp_cset, &mgctx->preloaded_src_csets,
> - mg_preload_node) {
> + mg_src_preload_node) {
> struct css_set *dst_cset;
> struct cgroup_subsys *ss;
> int ssid;
> @@ -2708,7 +2716,7 @@ int cgroup_migrate_prepare_dst(struct cgroup_mgctx *mgctx)
> if (src_cset == dst_cset) {
> src_cset->mg_src_cgrp = NULL;
> src_cset->mg_dst_cgrp = NULL;
> - list_del_init(&src_cset->mg_preload_node);
> + list_del_init(&src_cset->mg_src_preload_node);
> put_css_set(src_cset);
> put_css_set(dst_cset);
> continue;
> @@ -2716,8 +2724,8 @@ int cgroup_migrate_prepare_dst(struct cgroup_mgctx *mgctx)
>
> src_cset->mg_dst_cset = dst_cset;
>
> - if (list_empty(&dst_cset->mg_preload_node))
> - list_add_tail(&dst_cset->mg_preload_node,
> + if (list_empty(&dst_cset->mg_dst_preload_node))
> + list_add_tail(&dst_cset->mg_dst_preload_node,
> &mgctx->preloaded_dst_csets);
> else
> put_css_set(dst_cset);
> @@ -2963,7 +2971,8 @@ static int cgroup_update_dfl_csses(struct cgroup *cgrp)
> goto out_finish;
>
> spin_lock_irq(&css_set_lock);
> - list_for_each_entry(src_cset, &mgctx.preloaded_src_csets, mg_preload_node) {
> + list_for_each_entry(src_cset, &mgctx.preloaded_src_csets,
> + mg_src_preload_node) {
> struct task_struct *task, *ntask;
>
> /* all tasks in src_csets need to be migrated */
Powered by blists - more mailing lists