linux-kernel - [PATCH] lib/klist: Remove mb() before wake_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 22:44:43 +0800
From:   wuchi <wuchi.zero@...il.com>
To:     alexios.zavras@...el.com, allison@...utok.net, armijn@...ldur.nl
Cc:     akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] lib/klist: Remove mb() before wake_up_process

Function wake_up_process always executes a general memory barrier,
so remove the mb() before it.

Signed-off-by: wuchi <wuchi.zero@...il.com>
---
 lib/klist.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/klist.c b/lib/klist.c
index 332a4fbf18ff..c44498e31d91 100644
--- a/lib/klist.c
+++ b/lib/klist.c
@@ -194,7 +194,6 @@ static void klist_release(struct kref *kref)
 
 		list_del(&waiter->list);
 		waiter->woken = 1;
-		mb();
 		wake_up_process(waiter->process);
 	}
 	spin_unlock(&klist_remove_lock);
-- 
2.20.1