linux-kernel - Re: [PATCH 5.18 000/343] 5.18.4-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d993bbb6-e583-5d91-76c0-841cc5da86af@roeck-us.net>
Date:   Tue, 14 Jun 2022 08:33:56 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jaroslav Pulchart <jaroslav.pulchart@...ddata.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        slade@...dewatkins.com
Subject: Re: [PATCH 5.18 000/343] 5.18.4-rc2 review

On 6/14/22 08:03, Jaroslav Pulchart wrote:
> út 14. 6. 2022 v 16:56 odesílatel Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> napsal:
>>
>> On Tue, Jun 14, 2022 at 04:41:31PM +0200, Jaroslav Pulchart wrote:
>>> út 14. 6. 2022 v 8:34 odesílatel Greg Kroah-Hartman
>>> <gregkh@...uxfoundation.org> napsal:
>>>>
>>>> On Tue, Jun 14, 2022 at 07:56:36AM +0200, Jaroslav Pulchart wrote:
>>>>> Hello,
>>>>>
>>>>> I would like to report that the ethernet ice driver is not capable of
>>>>> setting promisc mode on at E810-XXV physical interface in the whole
>>>>> 5.18.y kernel line.
>>>>>
>>>>> Reproducer:
>>>>>     $ ip link set promisc on dev em1
>>>>> Dmesg error message:
>>>>>     Error setting promisc mode on VSI 6 (rc=-17)
>>>>>
>>>>> the problem was not observed with 5.17.y
>>>>
>>>> Any chance you can use 'git bisect' to track down the problem commit and
>>>> let the developers of it know?
>>>>
>>>> thanks,
>>>
>>> I tried it, but it makes the system unbootable. I expect the reason is
>>> that it happened somewhere between 5.17->5.18 so I'm using an
>>> "unstable" kernel.
>>>
>>> Is there some way I could bisect just one driver, not a full kernel
>>> between 5.17->5.18?
>>
>> How do you know it is just "one driver"?
> 
> Just a quess based on "git grep". The error message was introduced in
> the driver in 5.18-rc*.
> 

The message was introduced with commit 1273f89578f26 ("ice: Fix broken
IFF_ALLMULTI handling"). Given that commit message, it appears to be
at least somewhat likely that reverting this commit will fix your problem.
I would suggest to give it a try.

Guenter