linux-kernel - Re: [PATCH 3/3] arm64: dts: renesas: spider-cpu: Enable SCIF0 on second connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWJ9N1=X0O0LtpPrjH-uSbupKAVr+J3KwStL7xYgMxfWw@mail.gmail.com>
Date:   Tue, 14 Jun 2022 17:48:56 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: renesas: spider-cpu: Enable SCIF0 on
 second connector

Hi Wolfram,

On Mon, Jun 13, 2022 at 3:49 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
> The schematics label it as SCIF0 debug port.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> @@ -68,6 +68,11 @@ i2c4_pins: i2c4 {
>                 function = "i2c4";
>         };
>
> +       scif0_pins: scif0 {
> +               groups = "scif0_data", "scif0_ctrl";
> +               function = "scif0";
> +       };
> +
>         scif_clk_pins: scif_clk {
>                 groups = "scif_clk";
>                 function = "scif_clk";
> @@ -79,6 +84,14 @@ &rwdt {
>         status = "okay";
>  };
>
> +&scif0 {
> +       pinctrl-0 = <&scif0_pins>;
> +       pinctrl-names = "default";
> +
> +       uart-has-rtscts;
> +       status = "okay";
> +};
> +
>  &scif_clk {
>         clock-frequency = <24000000>;
>  };

This needs a new serial alias under /aliases.
Mixing dynamic and static serial IDs may cause conflicts, cfr. commit
7678f4c20fa7670f ("serial: sh-sci: Add support for dynamic instances").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds