lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jun 2022 17:14:57 +0100 From: Mark Rutland <mark.rutland@....com> To: Peter Zijlstra <peterz@...radead.org> Cc: rth@...ddle.net, ink@...assic.park.msu.ru, mattst88@...il.com, vgupta@...nel.org, linux@...linux.org.uk, ulli.kroll@...glemail.com, linus.walleij@...aro.org, shawnguo@...nel.org, Sascha Hauer <s.hauer@...gutronix.de>, kernel@...gutronix.de, festevam@...il.com, linux-imx@....com, tony@...mide.com, khilman@...nel.org, catalin.marinas@....com, will@...nel.org, guoren@...nel.org, bcain@...cinc.com, chenhuacai@...nel.org, kernel@...0n.name, geert@...ux-m68k.org, sammy@...my.net, monstr@...str.eu, tsbogend@...ha.franken.de, dinguyen@...nel.org, jonas@...thpole.se, stefan.kristiansson@...nalahti.fi, shorne@...il.com, James.Bottomley@...senPartnership.com, deller@....de, mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org, paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com, borntraeger@...ux.ibm.com, svens@...ux.ibm.com, ysato@...rs.sourceforge.jp, dalias@...c.org, davem@...emloft.net, richard@....at, anton.ivanov@...bridgegreys.com, johannes@...solutions.net, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, acme@...nel.org, alexander.shishkin@...ux.intel.com, jolsa@...nel.org, namhyung@...nel.org, jgross@...e.com, srivatsa@...il.mit.edu, amakhalov@...are.com, pv-drivers@...are.com, boris.ostrovsky@...cle.com, chris@...kel.net, jcmvbkbc@...il.com, rafael@...nel.org, lenb@...nel.org, pavel@....cz, gregkh@...uxfoundation.org, mturquette@...libre.com, sboyd@...nel.org, daniel.lezcano@...aro.org, lpieralisi@...nel.org, sudeep.holla@....com, agross@...nel.org, bjorn.andersson@...aro.org, anup@...infault.org, thierry.reding@...il.com, jonathanh@...dia.com, jacob.jun.pan@...ux.intel.com, Arnd Bergmann <arnd@...db.de>, yury.norov@...il.com, andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk, rostedt@...dmis.org, pmladek@...e.com, senozhatsky@...omium.org, john.ogness@...utronix.de, paulmck@...nel.org, frederic@...nel.org, quic_neeraju@...cinc.com, josh@...htriplett.org, mathieu.desnoyers@...icios.com, jiangshanlai@...il.com, joel@...lfernandes.org, juri.lelli@...hat.com, vincent.guittot@...aro.org, dietmar.eggemann@....com, bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com, jpoimboe@...nel.org, linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org, linux-snps-arc@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org, linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org, linux-ia64@...r.kernel.org, linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org, openrisc@...ts.librecores.org, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, linux-um@...ts.infradead.org, linux-perf-users@...r.kernel.org, virtualization@...ts.linux-foundation.org, xen-devel@...ts.xenproject.org, linux-xtensa@...ux-xtensa.org, linux-acpi@...r.kernel.org, linux-pm@...r.kernel.org, linux-clk@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-tegra@...r.kernel.org, linux-arch@...r.kernel.org, rcu@...r.kernel.org Subject: Re: [PATCH 16/36] rcu: Fix rcu_idle_exit() On Wed, Jun 08, 2022 at 04:27:39PM +0200, Peter Zijlstra wrote: > Current rcu_idle_exit() is terminally broken because it uses > local_irq_{save,restore}(), which are traced which uses RCU. > > However, now that all the callers are sure to have IRQs disabled, we > can remove these calls. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org> > Acked-by: Paul E. McKenney <paulmck@...nel.org> Acked-by: Mark Rutland <mark.rutland@....com> Mark. > --- > kernel/rcu/tree.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -659,7 +659,7 @@ static noinstr void rcu_eqs_enter(bool u > * If you add or remove a call to rcu_idle_enter(), be sure to test with > * CONFIG_RCU_EQS_DEBUG=y. > */ > -void rcu_idle_enter(void) > +void noinstr rcu_idle_enter(void) > { > lockdep_assert_irqs_disabled(); > rcu_eqs_enter(false); > @@ -896,13 +896,10 @@ static void noinstr rcu_eqs_exit(bool us > * If you add or remove a call to rcu_idle_exit(), be sure to test with > * CONFIG_RCU_EQS_DEBUG=y. > */ > -void rcu_idle_exit(void) > +void noinstr rcu_idle_exit(void) > { > - unsigned long flags; > - > - local_irq_save(flags); > + lockdep_assert_irqs_disabled(); > rcu_eqs_exit(false); > - local_irq_restore(flags); > } > EXPORT_SYMBOL_GPL(rcu_idle_exit); > > >
Powered by blists - more mailing lists