| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yqi60lnN6MQpysBw@hirez.programming.kicks-ass.net>
Date: Tue, 14 Jun 2022 18:44:02 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Nadav Amit <namit@...are.com>
Cc: "srivatsa@...il.mit.edu" <srivatsa@...il.mit.edu>,
"juri.lelli@...hat.com" <juri.lelli@...hat.com>,
"rafael@...nel.org" <rafael@...nel.org>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"bsegall@...gle.com" <bsegall@...gle.com>,
"guoren@...nel.org" <guoren@...nel.org>,
"pavel@....cz" <pavel@....cz>,
"agordeev@...ux.ibm.com" <agordeev@...ux.ibm.com>,
"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
linux-arch <linux-arch@...r.kernel.org>,
"vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
"mpe@...erman.id.au" <mpe@...erman.id.au>,
"chenhuacai@...nel.org" <chenhuacai@...nel.org>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
"agross@...nel.org" <agross@...nel.org>,
"geert@...ux-m68k.org" <geert@...ux-m68k.org>,
"linux-imx@....com" <linux-imx@....com>,
Catalin Marinas <catalin.marinas@....com>,
"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
"mattst88@...il.com" <mattst88@...il.com>,
"borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>,
"mturquette@...libre.com" <mturquette@...libre.com>,
"sammy@...my.net" <sammy@...my.net>,
"pmladek@...e.com" <pmladek@...e.com>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"jiangshanlai@...il.com" <jiangshanlai@...il.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
"linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>,
"acme@...nel.org" <acme@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"dietmar.eggemann@....com" <dietmar.eggemann@....com>,
"rth@...ddle.net" <rth@...ddle.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
LKML <linux-kernel@...r.kernel.org>,
"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
"senozhatsky@...omium.org" <senozhatsky@...omium.org>,
"svens@...ux.ibm.com" <svens@...ux.ibm.com>,
"jolsa@...nel.org" <jolsa@...nel.org>,
"paulus@...ba.org" <paulus@...ba.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Linux Virtualization <virtualization@...ts.linux-foundation.org>,
"James.Bottomley@...senpartnership.com"
<James.Bottomley@...senpartnership.com>,
"jcmvbkbc@...il.com" <jcmvbkbc@...il.com>,
"thierry.reding@...il.com" <thierry.reding@...il.com>,
"kernel@...0n.name" <kernel@...0n.name>,
"quic_neeraju@...cinc.com" <quic_neeraju@...cinc.com>,
linux-s390 <linux-s390@...r.kernel.org>,
"vschneid@...hat.com" <vschneid@...hat.com>,
"john.ogness@...utronix.de" <john.ogness@...utronix.de>,
"ysato@...rs.sourceforge.jp" <ysato@...rs.sourceforge.jp>,
"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
"festevam@...il.com" <festevam@...il.com>,
"deller@....de" <deller@....de>,
"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
"jonathanh@...dia.com" <jonathanh@...dia.com>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
"frederic@...nel.org" <frederic@...nel.org>,
"lenb@...nel.org" <lenb@...nel.org>,
"linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"gor@...ux.ibm.com" <gor@...ux.ibm.com>,
"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
"linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
"linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
"shorne@...il.com" <shorne@...il.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"chris@...kel.net" <chris@...kel.net>,
"sboyd@...nel.org" <sboyd@...nel.org>,
"dinguyen@...nel.org" <dinguyen@...nel.org>,
"bristot@...hat.com" <bristot@...hat.com>,
"alexander.shishkin@...ux.intel.com"
<alexander.shishkin@...ux.intel.com>,
"lpieralisi@...nel.org" <lpieralisi@...nel.org>,
"linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
"joel@...lfernandes.org" <joel@...lfernandes.org>,
Will Deacon <will@...nel.org>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
"khilman@...nel.org" <khilman@...nel.org>,
"linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>,
Pv-drivers <Pv-drivers@...are.com>,
"linux-snps-arc@...ts.infradead.org"
<linux-snps-arc@...ts.infradead.org>, Mel Gorman <mgorman@...e.de>,
"jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>,
Arnd Bergmann <arnd@...db.de>,
"ulli.kroll@...glemail.com" <ulli.kroll@...glemail.com>,
"vgupta@...nel.org" <vgupta@...nel.org>,
"josh@...htriplett.org" <josh@...htriplett.org>,
Steven Rostedt <rostedt@...dmis.org>,
"rcu@...r.kernel.org" <rcu@...r.kernel.org>,
Borislav Petkov <bp@...en8.de>,
"bcain@...cinc.com" <bcain@...cinc.com>,
"tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>,
"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
"sudeep.holla@....com" <sudeep.holla@....com>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"dalias@...c.org" <dalias@...c.org>,
"tony@...mide.com" <tony@...mide.com>,
"bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
"H. Peter Anvin" <hpa@...or.com>,
"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
"linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
Anton Ivanov <anton.ivanov@...bridgegreys.com>,
"jonas@...thpole.se" <jonas@...thpole.se>,
"yury.norov@...il.com" <yury.norov@...il.com>,
"richard@....at" <richard@....at>, X86 ML <x86@...nel.org>,
"linux@...linux.org.uk" <linux@...linux.org.uk>,
Ingo Molnar <mingo@...hat.com>,
"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
"paulmck@...nel.org" <paulmck@...nel.org>,
"hca@...ux.ibm.com" <hca@...ux.ibm.com>,
"stefan.kristiansson@...nalahti.fi"
<stefan.kristiansson@...nalahti.fi>,
"openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>,
"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
"namhyung@...nel.org" <namhyung@...nel.org>,
"andriy.shevchenko@...ux.intel.com"
<andriy.shevchenko@...ux.intel.com>,
"jpoimboe@...nel.org" <jpoimboe@...nel.org>,
Juergen Gross <jgross@...e.com>,
"monstr@...str.eu" <monstr@...str.eu>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
"palmer@...belt.com" <palmer@...belt.com>,
"anup@...infault.org" <anup@...infault.org>,
"ink@...assic.park.msu.ru" <ink@...assic.park.msu.ru>,
"johannes@...solutions.net" <johannes@...solutions.net>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more
PARAVIRT_XXL noinstr clean
On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote:
> On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat <srivatsa@...il.mit.edu> wrote:
>
> > ⚠ External Email
> >
> > On 6/8/22 4:27 PM, Peter Zijlstra wrote:
> >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd() leaves .noinstr.text section
> >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt() leaves .noinstr.text section
> >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section
> >>
> >> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> >
> > Reviewed-by: Srivatsa S. Bhat (VMware) <srivatsa@...il.mit.edu>
> >
> >>
> >> -static inline void wbinvd(void)
> >> +extern noinstr void pv_native_wbinvd(void);
> >> +
> >> +static __always_inline void wbinvd(void)
> >> {
> >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV));
> >> }
>
> I guess it is yet another instance of wrong accounting of GCC for
> the assembly blocks’ weight. I guess it is not a solution for older
> GCCs, but presumably ____PVOP_ALT_CALL() and friends should have
> used asm_inline or some new “asm_volatile_inline” variant.
Partially, some of the *SAN options also generate a metric ton of
nonsense when enabled and skew the compilers towards not inlining
things.
Powered by blists - more mailing lists