linux-kernel - Re: [PATCH v3 03/10] scsi: ufs-mediatek: Introduce workaround for power mode change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <386bfd16-e7be-7f80-cbaa-f55e01d3b070@acm.org>
Date:   Tue, 14 Jun 2022 09:46:09 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Stanley Chu <stanley.chu@...iatek.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, martin.petersen@...cle.com,
        avri.altman@....com, alim.akhtar@...sung.com, jejb@...ux.ibm.com
Cc:     peter.wang@...iatek.com, chun-hung.wu@...iatek.com,
        alice.chao@...iatek.com, powen.kao@...iatek.com,
        mason.zhang@...iatek.com, qilin.tan@...iatek.com,
        lin.gui@...iatek.com, eddie.huang@...iatek.com,
        tun-yu.yu@...iatek.com, cc.chou@...iatek.com,
        chaotian.jing@...iatek.com, jiajie.hao@...iatek.com,
        Peter Wang <peter.want@...aitek.com>
Subject: Re: [PATCH v3 03/10] scsi: ufs-mediatek: Introduce workaround for
 power mode change

On 6/14/22 07:16, Stanley Chu wrote:
> +	if ((dev_req_params->pwr_tx != FAST_MODE) &&
> +		(dev_req_params->gear_tx < UFS_HS_G4))
> +		return false;
> +
> +	if ((dev_req_params->pwr_rx != FAST_MODE) &&
> +		(dev_req_params->gear_rx < UFS_HS_G4))
> +		return false;

Please do not use more parentheses than needed. I think 8 parentheses 
can be left out from the above code.

Thanks,

Bart.