linux-kernel - Re: [PATCH] bitmap: fix a unproper remap when mpol_rebind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 19:50:28 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     wang.yi59@....com.cn, Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>, linux@...musvillemoes.dk,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        wang.liang82@....com.cn, Liu.Jianjun3@....com.cn
Subject: Re: [PATCH] bitmap: fix a unproper remap when mpol_rebind_nodemask()

On Tue, Jun 14, 2022 at 09:40:08AM -0700, Yury Norov wrote:
> On Mon, Jun 13, 2022 at 8:45 PM <wang.yi59@....com.cn> wrote:
> > > On Mon, Jun 13, 2022 at 4:31 AM Yi Wang <wang.yi59@....com.cn> wrote:

...

> > > Anyways, as per name, bitmap_remap() is intended to change bit
> > > positions, and it doesn't look wrong if it does so.

Haven't read the discussion in full, but saw the function here and my 2 cents
are the following:
 1) if we don't have tests for bitmap_remap() / bitmap_bitremap(), we should;
 2) these functions are used at least in one GPIO driver, so it would be nice
    to not touch them if they are not broken (see 1 above).

-- 
With Best Regards,
Andy Shevchenko