[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yqj575Z/tYXsRHHK@lunn.ch>
Date: Tue, 14 Jun 2022 23:13:19 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
linux-kernel@...r.kernel.org, bryan.whitehead@...rochip.com,
lxu@...linear.com, richardcochran@...il.com,
UNGLinuxDriver@...rochip.com, Ian.Saturley@...rochip.com
Subject: Re: [PATCH net-next 4/5] net: lan743x: Add support to SGMII 1G and
2.5G
> +/* MMD Device IDs */
> +#define STD_DEVID (0x0)
> +#define MMD_PMAPMD (0x1)
> +#define MMD_PCS (0x3)
> +#define MMD_ANEG (0x7)
> +#define MMD_VSPEC1 (0x1E)
> +#define MMD_VSPEC2 (0x1F)
Please use the values from include/uapi/mdio.h
> +
> +/* Vendor Specific SGMII MMD details */
> +#define SR_MII_DEV_ID1 0x0002
> +#define SR_MII_DEV_ID2 0x0003
MDIO_DEVID1 & MDIO_DEVID2
> +#define SR_VSMMD_PCS_ID1 0x0004
> +#define SR_VSMMD_PCS_ID2 0x0005
> +#define SR_VSMMD_STS 0x0008
> +#define SR_VSMMD_CTRL 0x0009
> +
> +#define SR_MII_CTRL 0x0000
> +#define SR_MII_CTRL_RST_ BIT(15)
> +#define SR_MII_CTRL_LBE_ BIT(14)
> +#define SR_MII_CTRL_SS13_ BIT(13)
> +#define SR_MII_CTRL_AN_ENABLE_ BIT(12)
> +#define SR_MII_CTRL_LPM_ BIT(11)
> +#define SR_MII_CTRL_RESTART_AN_ BIT(9)
> +#define SR_MII_CTRL_DUPLEX_MODE_ BIT(8)
> +#define SR_MII_CTRL_SS6_ BIT(6)
These look like standard BMCR registers. Please use the values from
mii.h
> +#define SR_MII_STS 0x0001
> +#define SR_MII_STS_ABL100T4_ BIT(15)
> +#define SR_MII_STS_FD100ABL_ BIT(14)
> +#define SR_MII_STS_HD100ABL_ BIT(13)
> +#define SR_MII_STS_FD10ABL_ BIT(12)
> +#define SR_MII_STS_HD10ABL_ BIT(11)
> +#define SR_MII_STS_FD100T_ BIT(10)
> +#define SR_MII_STS_HD100T_ BIT(9)
> +#define SR_MII_STS_EXT_STS_ABL_ BIT(8)
> +#define SR_MII_STS_UN_DIR_ABL_ BIT(7)
> +#define SR_MII_STS_MF_PRE_SUP_ BIT(6)
> +#define SR_MII_STS_AN_CMPL_ BIT(5)
> +#define SR_MII_STS_RF_ BIT(4)
> +#define SR_MII_STS_AN_ABL_ BIT(3)
> +#define SR_MII_STS_LINK_STS_ BIT(2)
> +#define SR_MII_STS_EXT_REG_CAP_ BIT(0)
These look like BMSR.
It could even be, you can just use generic code for these.
Andrew
Powered by blists - more mailing lists