linux-kernel - Re: [PATCH v10 06/10] docs: sysfs: coresight: Add sysfs ABI documentation for TPDM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05636dcb-91bd-a1a4-911b-6cdc7e359a5c@arm.com>
Date:   Tue, 14 Jun 2022 23:13:06 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Mao Jinlong <quic_jinlmao@...cinc.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Konrad Dybcio <konradybcio@...il.com>,
        Mike Leach <mike.leach@...aro.org>
Cc:     Leo Yan <leo.yan@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Tao Zhang <quic_taozha@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Hao Zhang <quic_hazha@...cinc.com>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH v10 06/10] docs: sysfs: coresight: Add sysfs ABI
 documentation for TPDM

On 11/06/2022 01:43, Mao Jinlong wrote:
> Add API usage document for sysfs API in TPDM driver.
> 
> Reviewed-by: Mike Leach <mike.leach@...aro.org>
> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
> ---
>   .../ABI/testing/sysfs-bus-coresight-devices-tpdm    | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>   create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> new file mode 100644
> index 000000000000..92bc09fbb69b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> @@ -0,0 +1,13 @@
> +What:		/sys/bus/coresight/devices/<tpdm-name>/integration_test
> +Date:		June 2022
> +KernelVersion	5.18

We have gone past this release. Please make this 5.20. Also, please 
merge this patch with the previous patch.

> +Contact:	Jinlong Mao (QUIC) <quic_jinlmao@...cinc.com>, Tao Zhang (QUIC) <quic_taozha@...cinc.com>
> +Description:
> +		(Write) Run integration test for tpdm. Integration test
> +		will generate test data for tpdm. It can help to make
> +		sure that the trace path is enabled and the link configurations
> +		are fine.
> +
> +		value to this sysfs node:

This is not entirely clear to me/reader. Could we say :

		Accepts only one of the 2 values -  1 or 2.
	
> +		1 : Generate 64 bits data
> +		2 : Generate 32 bits data


Suzuki