linux-kernel - Re: [PATCH] KVM: x86: Query vcpu->vcpu_idx directly and drop its accessor, again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALMp9eSYmxMRAGE3kZvJMsf53F1WJp397eJp3YvqitcsGzVi_Q@mail.gmail.com>
Date:   Tue, 14 Jun 2022 15:59:38 -0700
From:   Jim Mattson <jmattson@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Query vcpu->vcpu_idx directly and drop its
 accessor, again

On Tue, Jun 14, 2022 at 3:56 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> Read vcpu->vcpu_idx directly instead of bouncing through the one-line
> wrapper, kvm_vcpu_get_idx(), and drop the wrapper.  The wrapper is a
> remnant of the original implementation and serves no purpose; remove it
> (again) before it gains more users.
>
> kvm_vcpu_get_idx() was removed in the not-too-distant past by commit
> 4eeef2424153 ("KVM: x86: Query vcpu->vcpu_idx directly and drop its
> accessor"), but was unintentionally re-introduced by commit a54d806688fe
> ("KVM: Keep memslots in tree-based structures instead of array-based ones"),
> likely due to a rebase goof.  The wrapper then managed to gain users in
> KVM's Xen code.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

ROFL

Reviewed-by: Jim Mattson <jmattson@...gle.com>