linux-kernel - Re: [PATCH v3 5/5] PM / devfreq: Mute warning on governor PROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd320cfa-18fc-ef82-c25e-2652fd5cafbf@gmail.com>
Date:   Wed, 15 Jun 2022 08:10:55 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Christian 'Ansuel' Marangi <ansuelsmth@...il.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Sibi Sankar <sibis@...eaurora.org>,
        Saravana Kannan <skannan@...eaurora.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] PM / devfreq: Mute warning on governor PROBE_DEFER

On 22. 6. 14. 20:07, Christian 'Ansuel' Marangi wrote:
> Don't print warning when a governor PROBE_DEFER as it's not a real
> GOV_START fail.
> 
> Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@...il.com>
> ---
>  drivers/devfreq/devfreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 2e2b3b414d67..df6972bb0ce8 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -931,8 +931,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
>  	err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>  						NULL);
>  	if (err) {
> -		dev_err(dev, "%s: Unable to start governor for the device\n",
> -			__func__);
> +		dev_err_probe(dev, -EPROBE_DEFER, "%s: Unable to start governor for the device\n",
> +			      __func__);

Should use 'err' instead of -EPROBE_DEFER and please this line
as following in order to keep the 80 line indentation.

+               dev_err_probe(dev, err,
+                       "%s: Unable to start governor for the device\n",
+                       __func__)



>  		goto err_init;
>  	}
>  	create_sysfs_files(devfreq, devfreq->governor);


-- 
Best Regards,
Samsung Electronics
Chanwoo Choi