[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2d2a52db-70a8-788e-fedc-197789caa145@linux.intel.com>
Date: Tue, 14 Jun 2022 12:48:06 +0800
From: Baolu Lu <baolu.lu@...ux.intel.com>
To: "Tian, Kevin" <kevin.tian@...el.com>,
Joerg Roedel <joro@...tes.org>,
"Raj, Ashok" <ashok.raj@...el.com>,
Jason Gunthorpe <jgg@...dia.com>
Cc: baolu.lu@...ux.intel.com, "Liu, Yi L" <yi.l.liu@...el.com>,
"Pan, Jacob jun" <jacob.jun.pan@...el.com>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] iommu/vt-d: Add set_dev_pasid callbacks for default
domain
On 2022/6/14 12:02, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@...ux.intel.com>
>> Sent: Tuesday, June 14, 2022 11:44 AM
>>
>> This allows the upper layers to set a domain to a PASID of a device
>> if the PASID feature is supported by the IOMMU hardware. The typical
>> use cases are, for example, kernel DMA with PASID and hardware
>> assisted mediated device drivers.
>>
>
> why is it not part of the series for those use cases? There is no consumer
> of added callbacks in this patch...
It could be. I just wanted to maintain the integrity of Intel IOMMU
driver implementation.
>
>> +/* PCI domain-subdevice relationship */
>> +struct subdev_domain_info {
>> + struct list_head link_domain; /* link to domain siblings */
>> + struct device *dev; /* physical device derived from */
>> + ioasid_t pasid; /* PASID on physical device */
>> +};
>> +
>
> It's not subdev. Just dev+pasid in iommu's context.
How about struct device_pasid_info?
Best regards,
baolu
Powered by blists - more mailing lists