linux-kernel - Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed07ffc9-a6a9-7f7e-a34a-51c1a94ffe88@i2se.com>
Date:   Tue, 14 Jun 2022 08:34:51 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Ariel D'Alessandro <ariel.dalessandro@...labora.com>,
        Peter Robinson <pbrobinson@...il.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        gkrzysztof.kozlowski+dt@...aro.org, gnsaenz@...nel.org,
        grobh+dt@...nel.org, nsaenz@...nel.org,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC
 device index

Am 14.06.22 um 01:34 schrieb Florian Fainelli:
> On 6/13/22 05:46, Ariel D'Alessandro wrote:
>> Hi Peter,
>>
>> On 6/12/22 17:38, Peter Robinson wrote:
>>> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
>>> <ariel.dalessandro@...labora.com> wrote:
>>>>
>>>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>>>> change depending on the probe order of the MMC drivers.
>>>
>>> Is  the bcm2711-rpi.dtsi a better place for it given there's other
>>> aliases there and it will be consistent across variations?
>>
>> Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
>>
>> The other board what will be affected by this alias is the Raspberry Pi
>> Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
>> alias makes sense, to have that as the first mmc device.
>>
>> Maybe we can add the alias as follows?
>>
>>      mmc0 = &emmc2;  /* mmcblk0 for eMMC/SD */
>
> You have made a typo on the bcm-kernel-feedback-list meaning that this 
> won't reach the patchwork instance I use to manage and apply patches, 
> can you please fix that up for your v2? Thanks!
Not just the bcm-kernel-feedback-list is affected, also the address of 
Krzysztof, Rob and Nicolas has a g prepended.