linux-kernel - Re: [PATCH 1/2] ASoC: sun8i-codec: Partial revert to fix clock specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e105410-94d5-1801-8919-af8c0cef4de1@sholland.org>
Date:   Tue, 14 Jun 2022 01:39:20 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>, broonie@...nel.org
Cc:     matthias.bgg@...il.com, wens@...e.org, jernej.skrabec@...il.com,
        linux-mediatek@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        lgirdwood@...il.com, alsa-devel@...a-project.org,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: sun8i-codec: Partial revert to fix clock
 specifiers

Hi Charles,

On 6/13/22 11:15 AM, Charles Keepax wrote:
> Recent updates accidentally updated the clock producer/consumer
> specifiers on this device as part of refactoring the CPU side of the DAI
> links. However, this device sits on the CODEC side and shouldn't have
> been updated. Partially revert the changes keeping the switch to the new
> clock terminology but going back to the CODEC defines.
> 
> Fixes: 7cc3965fde74 ("ASoC: sunxi: Update to use set_fmt_new callback")
> Reported-by: Samuel Holland <samuel@...lland.org>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Reviewed-by: Samuel Holland <samuel@...lland.org>
Tested-by: Samuel Holland <samuel@...lland.org>

Thanks for the quick follow-up, and sorry for the confusion my earlier comment
caused. I verified that sound is broken (loud static) on a Pine A64-LTS board
with for-next, and is fixed by this patch.

Regards,
Samuel