linux-kernel - Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcbb81fc-848e-7de5-6a59-05d8c98b41d6@csgroup.eu>
Date:   Tue, 14 Jun 2022 07:12:18 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Wenhu Wang <wenhu.wang@...mail.com>
CC:     "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation



Le 14/06/2022 à 08:34, Greg KH a écrit :
> On Tue, Jun 14, 2022 at 06:09:35AM +0000, Wenhu Wang wrote:
>>>
>>> Odd indentation, did you use checkpatch.pl on your patch?
>>>
>>
>> Actually, I checked with the scripts, and there was no warning here.
>> I also checked in text editors and vim, if I translate tab with 4 spaces,
>> the "vma/mem" areas in the 5 lines were aligned.
> 
> Tabs in Linux are always 8 spaces wide.
> 

See 
https://docs.kernel.org/process/coding-style.html?highlight=coding+style#indentation

Tabs are 8 characters, and thus indentations are also 8 characters. 
There are heretic movements that try to make indentations 4 (or even 2!) 
characters deep, and that is akin to trying to define the value of PI to 
be 3.

Christophe