linux-kernel - Re: [PATCH v2 06/12] iommu/vt-d: Acquiring lock in domain ID allocation helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1b8cd0b-6f25-993e-5b96-ce90d855ef26@linux.intel.com>
Date:   Tue, 14 Jun 2022 15:22:46 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>,
        Joerg Roedel <joro@...tes.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        Christoph Hellwig <hch@...radead.org>,
        Jason Gunthorpe <jgg@...dia.com>
Cc:     baolu.lu@...ux.intel.com, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        "Liu, Yi L" <yi.l.liu@...el.com>,
        "Pan, Jacob jun" <jacob.jun.pan@...el.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 06/12] iommu/vt-d: Acquiring lock in domain ID
 allocation helpers

On 2022/6/14 14:52, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@...ux.intel.com>
>> Sent: Tuesday, June 14, 2022 10:52 AM
>>
>> The iommu->lock is used to protect the per-IOMMU domain ID resource.
>> Moving the lock into the ID alloc/free helpers makes the code more
>> compact. At the same time, the device_domain_lock is irrelevant to
>> the domain ID resource, remove its assertion as well.
>>
>> On the other hand, the iommu->lock is never used in interrupt context,
>> there's no need to use the irqsave variant of the spinlock calls.
> 
> I still prefer to separating reduction of lock ranges from changing irqsave.
> Locking is tricky. From bisect p.o.v. it will be a lot easier if we just change
> one logic in one patch.
> 

Fair enough. I will do this in the next version.

Best regards,
baolu