[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220614072414.dxdrzrcokusunf3v@pengutronix.de>
Date: Tue, 14 Jun 2022 09:24:14 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, michael@...rulasolutions.com,
Amarula patchwork <linux-amarula@...rulasolutions.com>,
Oliver Hartkopp <socketcan@...tkopp.net>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Vincent Mailhol <mailhol.vincent@...adoo.fr>,
Wolfgang Grandegger <wg@...ndegger.com>,
linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 05/13] can: netlink: dump bitrate 0 if
can_priv::bittiming.bitrate is -1U
On 13.06.2022 22:44:12, Dario Binacchi wrote:
> On Mon, Jun 13, 2022 at 9:11 AM Marc Kleine-Budde <mkl@...gutronix.de> wrote:
> > This would make the code a lot cleaner. Can you think of a nice macro
> > name for the -1?
> >
> > 0 could be CAN_BITRATE_UNCONFIGURED or _UNSET. For -1 I cannot find a
> > catchy name, something like CAN_BITRATE_CONFIGURED_UNKOWN or
> > SET_UNKNOWN.
> >
>
> Personally I would use CAN_BITRATE_UNSET (0) and CAN_BITRATE_UNKNOWN (-1).
> Let me know what your ultimate preference is.
Looks good.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists