linux-kernel - Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220614074835.qto55feu74ionlh5@gator>
Date:   Tue, 14 Jun 2022 09:48:35 +0200
From:   Andrew Jones <drjones@...hat.com>
To:     shaoqin.huang@...el.com
Cc:     pbonzini@...hat.com, Shuah Khan <shuah@...nel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        David Matlack <dmatlack@...gle.com>,
        Marc Zyngier <maz@...nel.org>,
        Oliver Upton <oupton@...gle.com>,
        Ricardo Koller <ricarkol@...gle.com>,
        Wei Wang <wei.w.wang@...el.com>,
        Peter Gonda <pgonda@...gle.com>,
        David Dunn <daviddunn@...gle.com>, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments

On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@...el.com wrote:
> From: Shaoqin Huang <shaoqin.huang@...el.com>
> 
> There are some parameter being removed in function but the parameter
> comments still exist, so remove them.
> 
> Signed-off-by: Shaoqin Huang <shaoqin.huang@...el.com>
> ---
>  tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1665a220abcb..58fdc82b20f4 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
>   *   vm - Virtual Machine
>   *   sz - Size in bytes
>   *   vaddr_min - Minimum starting virtual address
> - *   data_memslot - Memory region slot for data pages
> - *   pgd_memslot - Memory region slot for new virtual translation tables
>   *
>   * Output Args: None
>   *
> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
>   *   vaddr - Virtuall address to map
>   *   paddr - VM Physical Address
>   *   npages - The number of pages to map
> - *   pgd_memslot - Memory region slot for new virtual translation tables
>   *
>   * Output Args: None
>   *
> -- 
> 2.30.2
>

Hi Shaoqin,

Please check kvm/queue, the extra parameter comments have already been
removed.

Thanks,
drew