linux-kernel - Re: [PATCH 0/4] KVM: selftests: Fixups for overhaul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220614075106.463oqkerlaximxfl@gator>
Date:   Tue, 14 Jun 2022 09:51:06 +0200
From:   Andrew Jones <drjones@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] KVM: selftests: Fixups for overhaul

On Mon, Jun 13, 2022 at 04:19:38PM +0000, Sean Christopherson wrote:
> Fixups for the overhaul, all of which come from Drew's code review.  The
> first three should all squash cleanly, but the kvm_check_cap() patch will
> not due to crossing the TEST_REQUIRE() boundary.
> 
> Sean Christopherson (4):
>   KVM: selftests: Add a missing apostrophe in comment to show ownership
>   KVM: selftests: Call a dummy helper in VM/vCPU ioctls() to enforce
>     type
>   KVM: selftests: Drop a duplicate TEST_ASSERT() in
>     vm_nr_pages_required()
>   KVM: selftests: Use kvm_has_cap(), not kvm_check_cap(), where possible
> 
>  .../testing/selftests/kvm/aarch64/psci_test.c |  2 +-
>  .../selftests/kvm/include/kvm_util_base.h     | 57 ++++++++++---------
>  tools/testing/selftests/kvm/lib/kvm_util.c    |  6 +-
>  .../selftests/kvm/lib/x86_64/processor.c      |  4 +-
>  .../selftests/kvm/s390x/sync_regs_test.c      |  2 +-
>  .../kvm/x86_64/pmu_event_filter_test.c        |  2 +-
>  .../selftests/kvm/x86_64/sev_migrate_tests.c  |  6 +-
>  tools/testing/selftests/kvm/x86_64/smm_test.c |  2 +-
>  .../testing/selftests/kvm/x86_64/state_test.c |  2 +-
>  9 files changed, 42 insertions(+), 41 deletions(-)
> 
> 
> base-commit: 8baacf67c76c560fed954ac972b63e6e59a6fba0
> -- 
> 2.36.1.476.g0c4daa206d-goog
>

All these patches look good to me. For the series

Reviewed-by: Andrew Jones <drjones@...hat.com>

There's still one more comment I made on the overhaul though, which
is that the expressions using i and j in kvm_binary_stats_test.c
for the vcpus and vcpu_stat_test indices have i and j swapped.

Thanks,
drew