linux-kernel - Re: [PATCH 1/1] l2tp: fix possible use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <289be1e1392d5a0c9a90486be44ad09d10b70752.camel@redhat.com>
Date:   Tue, 14 Jun 2022 10:06:20 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Xiaohui Zhang <xiaohuizhang@....edu.cn>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>,
        Xin Xiong <xiongx18@...an.edu.cn>,
        Tom Parkin <tparkin@...alix.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] l2tp: fix possible use-after-free

On Fri, 2022-06-10 at 13:16 +0800, Xiaohui Zhang wrote:
> Similar to the handling of l2tp_tunnel_get in commit a622b40035d1
> ("l2ip: fix possible use-after-free"), we thought a patch might
> be needed here as well.
> 
> Before taking a refcount on a rcu protected structure,
> we need to make sure the refcount is not zero.
> 
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@....edu.cn>

I'm sorry for the late, trivial feedback, but we need a Fixes: tag
here. Since you need to repost, please insert the target tree
explicitly into the email subj.

Thanks!

Paolo