linux-kernel - RE: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 08:48:33 +0000
From:   "Yuan, Perry" <Perry.Yuan@....com>
To:     "Huang, Ray" <Ray.Huang@....com>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        Jane Malalane <jane.malalane@...rix.com>,
        "Phillips, Kim" <kim.phillips@....com>,
        Tony Luck <tony.luck@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@....com>,
        "Meng, Li (Jassmine)" <Li.Meng@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: RE: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new
 AMD processors

[AMD Official Use Only - General]

Hi Ray.

> -----Original Message-----
> From: Huang, Ray <Ray.Huang@....com>
> Sent: Tuesday, June 14, 2022 4:42 PM
> To: Yuan, Perry <Perry.Yuan@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar <mingo@...hat.com>;
> Borislav Petkov <bp@...en8.de>; Dave Hansen <dave.hansen@...ux.intel.com>;
> x86@...nel.org; H. Peter Anvin <hpa@...or.com>; Lendacky, Thomas
> <Thomas.Lendacky@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>; Jane Malalane <jane.malalane@...rix.com>;
> Phillips, Kim <kim.phillips@....com>; Tony Luck <tony.luck@...el.com>; linux-
> kernel@...r.kernel.org; Su, Jinzhou (Joe) <Jinzhou.Su@....com>; Meng, Li
> (Jassmine) <Li.Meng@....com>; linux-pm@...r.kernel.org
> Subject: Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new
> AMD processors
> 
> On Tue, Jun 14, 2022 at 11:52:28AM +0800, Yuan, Perry wrote:
> > In order to get the corrent highest perf for some new AMD processors,
> > the amd_get_highest_perf() call will check the CPU model and return
> > correct highest perf value.
> >
> 
> You needs to change the prefix of the subject, because it's not the amd-pstate
> driver.
> 
> x86/amd: Fix the highest perf query for new AMD processors
> 
> Thanks,
> Ray

Thanks for reminding me that.
Will update the title as below. Sending V2.

x86/cpu/amd: fix the highest perf query for new AMD processors

Perry.

> 
> > Signed-off-by: Perry Yuan <Perry.Yuan@....com>
> > ---
> >  arch/x86/kernel/cpu/amd.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> > index 0c0b09796ced..ff2075f26ef4 100644
> > --- a/arch/x86/kernel/cpu/amd.c
> > +++ b/arch/x86/kernel/cpu/amd.c
> > @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
> >  	struct cpuinfo_x86 *c = &boot_cpu_data;
> >
> >  	if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40)
> ||
> > -			       (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> > +			       (c->x86_model >= 0x70 && c->x86_model < 0x80)
> ||
> > +			       (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
> >  		return 166;
> >
> >  	if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30)
> > ||
> > --
> > 2.25.1
> >