[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdLMCBhhM4P_asTf7r+OhBHmgJVCg7MADkOYRTf1JvRaA@mail.gmail.com>
Date: Tue, 14 Jun 2022 11:27:21 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Gwendal Grignou <gwendal@...omium.org>
Cc: Jonathan Cameron <jic23@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
linux-iio <linux-iio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/1] iio: proximity: sx_common: Allow IIO core to take
care of firmware node
On Mon, Jun 13, 2022 at 11:31 PM Gwendal Grignou <gwendal@...omium.org> wrote:
>
> The reason we have the code ACPI_COMPANION_SET and dev.of_node set (by
> commit 74a53a959028e ("iio:proximity:sx_common: Fix device property
> parsing on DT systems") from Stephen is we are getting device propery
> in ->get_default_reg(), which is called in sx_common_init_device(),
> before devm_iio_device_register().
>
> We have the same code path in other driver, like adc/stm32-adc.c,
> where indio_dev->dev.of_node is set manually to be able to set the
> resolution based on device tree properties.
Ah, thanks for this insight! I will rework the patch accordingly (yes,
there is something to clean up even in this case).
> On Fri, Jun 3, 2022 at 9:57 AM Jonathan Cameron <jic23@...nel.org> wrote:
> > On Mon, 30 May 2022 20:43:26 +0300
> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > > IIO core correctly will take care of firmware node if it's not set in
> > > the driver. Drop ACPI and OF specifics from the driver and allow IIO
> > > core to handle this.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Looks fine to me. As such I'll apply it now, but Gwendal, you've
> > been active with this driver recently so if you have time to sanity check
> > that would be great. Once I've caught up with new stuff I plan to check
> > where we are with your various series on this driver.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists