linux-kernel - Re: regulator: BD71837 PMIC resume during noirq phase?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8024d9e3b885941084740cb0fb2fc9117acdd069.camel@puri.sm>
Date:   Tue, 14 Jun 2022 11:57:18 +0200
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Mark Brown <broonie@...nel.org>
Cc:     matti.vaittinen@...rohmeurope.com, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        arm-soc <linux-arm-kernel@...ts.infradead.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: regulator: BD71837 PMIC resume during noirq phase?

Am Dienstag, dem 14.06.2022 um 10:18 +0100 schrieb Mark Brown:
> On Tue, Jun 14, 2022 at 11:06:06AM +0200, Martin Kepplinger wrote:
> 
> > and regulator_enable() in imx-pgc is called from
> > genpd_resume_noirq().
> > 
> > At this point, does any workaround or fix come to your mind I could
> > test? I guess i2c needs to be resumed too...
> > 
> > Why does power domain only implement resume_noirq? How could I
> > untangle
> > this?
> 
> Indeed - if a power domain is controlling regulators then I'd not
> expect
> things to go well if it tries to resume without interrupts, there
> will
> be some things that can be done purely with GPIOs but that's
> depending
> on the hardware having wired things up that way and the operations
> needed by the power domain mapping well onto what can be done with
> GPIOs.

and what's the danger when resuming power domains later?:

--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2062,8 +2062,8 @@ int pm_genpd_init(struct generic_pm_domain
*genpd,
        genpd->domain.ops.runtime_suspend = genpd_runtime_suspend;
        genpd->domain.ops.runtime_resume = genpd_runtime_resume;
        genpd->domain.ops.prepare = genpd_prepare;
-       genpd->domain.ops.suspend_noirq = genpd_suspend_noirq;
-       genpd->domain.ops.resume_noirq = genpd_resume_noirq;
+       genpd->domain.ops.suspend = genpd_suspend_noirq;
+       genpd->domain.ops.resume = genpd_resume_noirq;
        genpd->domain.ops.freeze_noirq = genpd_freeze_noirq;
        genpd->domain.ops.thaw_noirq = genpd_thaw_noirq;
        genpd->domain.ops.poweroff_noirq = genpd_poweroff_noirq;


thanks for taking the time,

                          martin