lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jun 2022 12:40:35 +0200 From: Ansuel Smith <ansuelsmth@...il.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Mark Mentovai <mark@...ienet.com> Subject: Re: [net-next PATCH 2/2] net: ethernet: stmmac: reset force speed bit for ipq806x On Mon, Jun 13, 2022 at 10:49:17PM -0700, Jakub Kicinski wrote: > On Thu, 9 Jun 2022 02:28:31 +0200 Christian 'Ansuel' Marangi wrote: > > + dn = of_get_child_by_name(pdev->dev.of_node, "fixed-link"); > > + ret = of_property_read_u32(dn, "speed", &link_speed); > > + if (ret) { > > + dev_err(dev, "found fixed-link node with no speed"); > > + return ret; > > Doesn't this return potentially leak the reference on dn? > You move the of_node_put() right before the if (ret) { > Totally right. Will fix in v2. > > + } > > + > > + of_node_put(dn); -- Ansuel
Powered by blists - more mailing lists