linux-kernel - Re: [kbuild-all] Re: [PATCH 1/8] perf: Consolidate branch sample filter helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4cadb9a-2363-f446-0fce-1242e84396bc@intel.com>
Date:   Tue, 14 Jun 2022 19:13:09 +0800
From:   "Chen, Rong A" <rong.a.chen@...el.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        kernel test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        peterz@...radead.org, acme@...nel.org, mark.rutland@....com,
        will@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Catalin Marinas <catalin.marinas@....com>,
        James Clark <james.clark@....com>,
        Rob Herring <robh@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-perf-users@...r.kernel.org
Subject: Re: [kbuild-all] Re: [PATCH 1/8] perf: Consolidate branch sample
 filter helpers



On 6/14/2022 9:36 AM, Anshuman Khandual wrote:
> 
> On 6/14/22 02:02, kernel test robot wrote:
>> Hi Anshuman,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on tip/perf/core]
>> [also build test ERROR on acme/perf/core]
>> [cannot apply to arm64/for-next/core]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220613-180501
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git f0fe9f3c7abcc946a676dfb295478c50312523c2
>> config: x86_64-randconfig-a002-20220613 (https://download.01.org/0day-ci/archive/20220614/202206140422.ttLxMHtq-lkp@intel.com/config)
>> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d378268ead93c85803c270277f0243737b536ae7)
>> reproduce (this is a W=1 build):
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # https://github.com/intel-lab-lkp/linux/commit/1bd23b8ca1fc92f2f5b28a94ebd95432febfe96c
>>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>>          git fetch --no-tags linux-review Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220613-180501
>>          git checkout 1bd23b8ca1fc92f2f5b28a94ebd95432febfe96c
>>          # save the config file
>>          mkdir build_dir && cp config build_dir/.config
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/
>>
>> If you fix the issue, kindly add following tag where applicable
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     In file included from drivers/acpi/acpi_pad.c:20:
>>>> include/linux/perf_event.h:1708:42: error: use of undeclared identifier 'PERF_SAMPLE_BRANCH_PRIV_SAVE'; did you mean 'PERF_SAMPLE_BRANCH_TYPE_SAVE'?
>>             return event->attr.branch_sample_type & PERF_SAMPLE_BRANCH_PRIV_SAVE;
>>                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>                                                     PERF_SAMPLE_BRANCH_TYPE_SAVE
>>     include/uapi/linux/perf_event.h:231:2: note: 'PERF_SAMPLE_BRANCH_TYPE_SAVE' declared here
>>             PERF_SAMPLE_BRANCH_TYPE_SAVE    =
>>             ^
>>     1 error generated.
> 
> This series is dependent on another one which adds symbol PERF_SAMPLE_BRANCH_TYPE_SAVE
> as mentioned in the cover letter. I understand the '--base' argument for git format-patch
> output, but how to mention another prerequisite series before this can be built tested ?

Hi Anshuman,

git format-patch supports to set prerequisite-patch-id, kernel test robot
can parse the information and apply patch to a proper branch to test.

    https://git-scm.com/docs/git-format-patch#_base_tree_information

Best Regards,
Rong Chen