linux-kernel - Re: [PATCH 1/4] leds: class: simplify the implementation of devm_of_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 17:52:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jean-Jacques Hiblot <jjhiblot@...phandler.com>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        johan+linaro@...nel.org,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] leds: class: simplify the implementation of devm_of_led_get()

On Wed, Jun 15, 2022 at 5:49 PM Jean-Jacques Hiblot
<jjhiblot@...phandler.com> wrote:
>
> Use the devm_add_action_or_reset() helper.

...

> @@ -20,8 +20,10 @@
>  #include <linux/timer.h>
>  #include <uapi/linux/uleds.h>
>  #include <linux/of.h>
> +#include <linux/acpi.h>
>  #include "leds.h"
>
> +
>  static struct class *leds_class;
>
>  static ssize_t brightness_show(struct device *dev,

Stray changes.

...

> +       led_put((struct led_classdev *) cdev);

Casting from/to void * is redundant.

-- 
With Best Regards,
Andy Shevchenko