linux-kernel - Re: [PATCH 04/11] platform/chrome: cros_ec_proto: separate cros_ec_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTcnB8cQgWOLm5tTxzoUxAZ2Q5=nv0xirtNNOBf5th2Zyg@mail.gmail.com>
Date:   Wed, 15 Jun 2022 09:35:52 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Tzung-Bi Shih <tzungbi@...nel.org>
Cc:     Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        "open list:CHROME HARDWARE PLATFORM SUPPORT" 
        <chrome-platform@...ts.linux.dev>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/11] platform/chrome: cros_ec_proto: separate cros_ec_xfer_command()

On Tue, Jun 14, 2022 at 10:13 PM Tzung-Bi Shih <tzungbi@...nel.org> wrote:
>
> cros_ec_send_command() has extra logic to handle EC_RES_IN_PROGRESS.
> Separate the command transfer part into cros_ec_xfer_command() so
> that other functions can re-use it.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@...nel.org>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>  drivers/platform/chrome/cros_ec_proto.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> index b02fd1414e52..0cec013be3d3 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -107,7 +107,7 @@ static int prepare_tx_legacy(struct cros_ec_device *ec_dev,
>         return EC_MSG_TX_PROTO_BYTES + msg->outsize;
>  }
>
> -static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
> +static int cros_ec_xfer_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
>  {
>         int ret;
>         int (*xfer_fxn)(struct cros_ec_device *ec, struct cros_ec_command *msg);
> @@ -123,14 +123,21 @@ static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_co
>                  * the EC is trying to use protocol v2, on an underlying
>                  * communication mechanism that does not support v2.
>                  */
> -               dev_err_once(ec_dev->dev,
> -                            "missing EC transfer API, cannot send command\n");
> +               dev_err_once(ec_dev->dev, "missing EC transfer API, cannot send command\n");
>                 return -EIO;
>         }
>
>         trace_cros_ec_request_start(msg);
>         ret = (*xfer_fxn)(ec_dev, msg);
>         trace_cros_ec_request_done(msg, ret);
> +
> +       return ret;
> +}
> +
> +static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)
> +{
> +       int ret = cros_ec_xfer_command(ec_dev, msg);
> +
>         if (msg->result == EC_RES_IN_PROGRESS) {
>                 int i;
>                 struct cros_ec_command *status_msg;
> --
> 2.36.1.476.g0c4daa206d-goog
>