linux-kernel - Re: [PATCH net-next v2 0/5] net: dsa: realtek: rtl8365mb: improve handling of PHY modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220615165529.3g6aqwdpwxqhs6nj@bang-olufsen.dk>
Date:   Wed, 15 Jun 2022 16:55:29 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Alvin Šipraga <alvin@...s.dk>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "hauke@...ke-m.de" <hauke@...ke-m.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/5] net: dsa: realtek: rtl8365mb: improve
 handling of PHY modes

David, Jakub, this series is marked Changes Requested on patchwork, but I have
addressed all the comments. Do you want me to resend?

Kind regards,
Alvin

On Fri, Jun 10, 2022 at 05:38:24PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
> 
> This series introduces some minor cleanup of the driver and improves the
> handling of PHY interface modes to break the assumption that CPU ports
> are always over an external interface, and the assumption that user
> ports are always using an internal PHY.
> 
> Changes v1 -> v2:
> 
>  - patches 1-4: no code change
> 
>  - add Luiz' reviewed-by to some of the patches
> 
>  - patch 5: put the chip_infos into a static array and get rid of the
>    switch in the detect function; also remove the macros for various
>    chip ID/versions and embed them directly into the array
> 
>  - patch 5: use array of size 3 rather than flexible array for extints
>    in the chip_info struct; gcc complained about initialization of
>    flexible array members in a nested context, and anyway, we know that
>    the max number of external interfaces is 3
> 
> Alvin Šipraga (5):
>   net: dsa: realtek: rtl8365mb: rename macro RTL8367RB -> RTL8367RB_VB
>   net: dsa: realtek: rtl8365mb: remove port_mask private data member
>   net: dsa: realtek: rtl8365mb: correct the max number of ports
>   net: dsa: realtek: rtl8365mb: remove learn_limit_max private data
>     member
>   net: dsa: realtek: rtl8365mb: handle PHY interface modes correctly
> 
>  drivers/net/dsa/realtek/rtl8365mb.c | 299 ++++++++++++++++------------
>  1 file changed, 177 insertions(+), 122 deletions(-)
> 
> -- 
> 2.36.1
>