linux-kernel - Re: linux-next: Tree for Jun 15 (drivers/dma/apple-admac.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <334755C8-8FF2-49D3-ACC3-C76F3BCCBB4F@cutebit.org>
Date:   Wed, 15 Jun 2022 19:23:37 +0200
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        dmaengine@...r.kernel.org
Subject: Re: linux-next: Tree for Jun 15 (drivers/dma/apple-admac.c)


> On 15. 6. 2022, at 19:10, Arnd Bergmann <arnd@...db.de> wrote:
> 
> On Wed, Jun 15, 2022 at 6:28 PM Randy Dunlap <rdunlap@...radead.org> wrote:

>> On 6/14/22 23:01, Stephen Rothwell wrote:
>>> Hi all,
>>> 
>>> Changes since 20220614:
>>> 
>> 
>> on i386:
>> 
>> ../drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
>> ../drivers/dma/apple-admac.c:213:22: warning: right shift count >= width of type [-Wshift-count-overflow]
>>  writel_relaxed(addr >> 32,       ad->base + REG_DESC_WRITE(channo));
>>                      ^
> 
> This should probably use lower_32_bits()/upper_32_bits() then.
> 
>       Arnd

Here’s a patch to use lower/upper_32_bits that’s been posted.

https://lore.kernel.org/dmaengine/20220614074915.1443629-1-geert@linux-m68k.org/

Martin