linux-kernel - Re: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU cap KVM_CAP_X86_DISABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220615031407.GC7808@gao-cwp>
Date:   Wed, 15 Jun 2022 11:14:12 +0800
From:   Chao Gao <chao.gao@...el.com>
To:     Kechen Lu <kechenl@...dia.com>
Cc:     kvm@...r.kernel.org, pbonzini@...hat.com, seanjc@...gle.com,
        vkuznets@...hat.com, somduttar@...dia.com,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU cap
 KVM_CAP_X86_DISABLE_EXITS

>+/* Set debug control for trapped instruction exiting to userspace */
>+static void vcpu_set_debug_exit_userspace(struct kvm_vm *vm, int vcpuid,
>+		struct kvm_guest_debug *debug) {

The debug argument looks pointless. Probably you can remove it.

>+	memset(debug, 0, sizeof(*debug));
>+	debug->control = KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_EXIT_USERSPACE;
>+	vcpu_set_guest_debug(vm, VCPU_ID_1, debug);
>+}