[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220615182846.oliacmkrivhh5kx7@liuwe-devbox-debian-v2>
Date: Wed, 15 Jun 2022 18:28:46 +0000
From: Wei Liu <wei.liu@...nel.org>
To: "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
Cc: Tianyu Lan <ltykernel@...il.com>,
KY Srinivasan <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Stephen Hemminger <sthemmin@...rosoft.com>,
"wei.liu@...nel.org" <wei.liu@...nel.org>,
Dexuan Cui <decui@...rosoft.com>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"bp@...en8.de" <bp@...en8.de>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
Tianyu Lan <Tianyu.Lan@...rosoft.com>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
vkuznets <vkuznets@...hat.com>,
"parri.andrea@...il.com" <parri.andrea@...il.com>,
"thomas.lendacky@....com" <thomas.lendacky@....com>
Subject: Re: [PATCH V3] x86/Hyper-V: Add SEV negotiate protocol support in
Isolation VM
On Tue, Jun 14, 2022 at 04:50:36PM +0000, Michael Kelley (LINUX) wrote:
> From: Tianyu Lan <ltykernel@...il.com> Sent: Monday, June 13, 2022 6:46 PM
> >
> > Hyper-V Isolation VM current code uses sev_es_ghcb_hv_call()
> > to read/write MSR via GHCB page and depends on the sev code.
> > This may cause regression when sev code changes interface
> > design.
> >
> > The latest SEV-ES code requires to negotiate GHCB version before
> > reading/writing MSR via GHCB page and sev_es_ghcb_hv_call() doesn't
> > work for Hyper-V Isolation VM. Add Hyper-V ghcb related implementation
> > to decouple SEV and Hyper-V code. Negotiate GHCB version in the
> > hyperv_init() and use the version to communicate with Hyper-V
> > in the ghcb hv call function.
> >
> > Fixes: 2ea29c5abbc2 ("x86/sev: Save the negotiated GHCB version")
> > Signed-off-by: Tianyu Lan <Tianyu.Lan@...rosoft.com>
> > ---
> > Change since v1:
> > - Negotiate ghcb version in Hyper-V init.
> > - use native_wrmsrl() instead of native_wrmsr() in the
> > wr_ghcb_msr().
> > ---
> > arch/x86/hyperv/hv_init.c | 6 +++
> > arch/x86/hyperv/ivm.c | 84 ++++++++++++++++++++++++++++++---
> > arch/x86/include/asm/mshyperv.h | 4 ++
> > 3 files changed, 88 insertions(+), 6 deletions(-)
> >
>
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
>
Applied to hyperv-fixes. Thanks.
Powered by blists - more mailing lists