linux-kernel - Re: [PATCH] perf io: Make open and read calls more robust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fVAUGMENJhD9d7VA9TbO1JOLJhisDPymJZgW0zr7WDXNA@mail.gmail.com>
Date:   Wed, 15 Jun 2022 12:17:15 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexey Bayduraev <alexey.v.bayduraev@...ux.intel.com>,
        Riccardo Mancini <rickyman7@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Dave Marchevsky <davemarchevsky@...com>,
        Song Liu <songliubraving@...com>, Leo Yan <leo.yan@...aro.org>,
        John Garry <john.garry@...wei.com>,
        Florian Fischer <florian.fischer@...q.space>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Zechuan Chen <chenzechuan1@...wei.com>,
        Yang Jihong <yangjihong1@...wei.com>,
        German Gomez <german.gomez@....com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        James Clark <james.clark@....com>,
        Denis Nikitin <denik@...omium.org>,
        Lexi Shao <shaolexi@...wei.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Remi Bernon <rbernon@...eweavers.com>,
        Fangrui Song <maskray@...gle.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf io: Make open and read calls more robust

On Wed, Jun 15, 2022 at 11:47 AM Andi Kleen <ak@...ux.intel.com> wrote:
>
>
> On 6/14/2022 11:03 PM, Ian Rogers wrote:
> > Wrap open and read calls with TEMP_FAILURE_RETRY in case a signal
> > causes the syscall to need to restart.
>
>
> Why not just use SA_RESTART on the signals?

As explained to Adrian, existing code is EINTR tolerant, some of the
code is in libraries and for portability shouldn't assume SA_RESTART.

Thanks,
Ian

>
> -Andi
>