linux-kernel - Re: [PATCH v2 2/4] clk: qcom: clk-rcg2: Make sure to not write d=0 to the NMD register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 12:41:29 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Nikita Travkin <nikita@...n.ru>, linus.walleij@...aro.org,
        mturquette@...libre.com
Cc:     bjorn.andersson@...aro.org, agross@...nel.org, tdas@...eaurora.org,
        joonwoop@...eaurora.org, svarbanov@...sol.com,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Nikita Travkin <nikita@...n.ru>
Subject: Re: [PATCH v2 2/4] clk: qcom: clk-rcg2: Make sure to not write d=0 to the NMD register

Quoting Nikita Travkin (2022-06-12 07:59:53)
> Sometimes calculation of d value may result in 0 because of the
> rounding after integer division. This causes the following error:
> 
> [  113.969689] camss_gp1_clk_src: rcg didn't update its configuration.
> [  113.969754] WARNING: CPU: 3 PID: 35 at drivers/clk/qcom/clk-rcg2.c:122 update_config+0xc8/0xdc
> 
> Make sure that D value is never zero.
> 
> Fixes: 7f891faf596e ("clk: qcom: clk-rcg2: Add support for duty-cycle for RCG")
> Signed-off-by: Nikita Travkin <nikita@...n.ru>
> 
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>