linux-kernel - Re: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220615221344.308bf5da@jic23-huawei>
Date:   Wed, 15 Jun 2022 22:13:44 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Sa, Nuno" <Nuno.Sa@...log.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper
 header files

On Wed, 15 Jun 2022 22:09:30 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Wed, 15 Jun 2022 12:15:48 +0000
> "Sa, Nuno" <Nuno.Sa@...log.com> wrote:
> 
> > Hi Andy,
> >   
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > Sent: Wednesday, June 15, 2022 2:08 PM
> > > To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>;
> > > Alexandru Ardelean <aardelean@...iqon.com>; linux-
> > > iio@...r.kernel.org; linux-kernel@...r.kernel.org
> > > Cc: Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen
> > > <lars@...afoo.de>
> > > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper
> > > header files
> > > 
> > > [External]
> > > 
> > > Do not trust the fact that iio.h includes of.h which in turn includes
> > > all the headers we are relying on.
> > > 
> > > The ultimate goal is to actually drop of.h from iio.h.
> > > 
> > > Signed-off-by: Andy Shevchenko
> > > <andriy.shevchenko@...ux.intel.com>
> > > ---
> > > 
> > > Jonathan, this should be squeezed before we remove of.h in iio.h
> > > I think Nuno somehow missed this    
> > 
> > Yes, I did (compile) tested this on arm and arm64 as I said in the cover.
> > I guess this one won't be enabled on those archs :).
> > 
> > I was planning to send this on v2 (I did noticed the kernel test bot
> > emails) but yeah, this should actually be included with the other
> > patches before removing of.h from iio. Thanks!
> > 
> > Reviewed-by: Nuno Sá <nuno.sa@...log.com>  
> 
> Applied.  Oddly didn't show up in my normal x86 build test.
Figured out the chain of necessary dependencies so I'll catch anything
effecting this in my smoke test build going forwards.

Thanks,

Jonathan

> 
> As suggested, slotted in before the of.h removal patch.
> 
> Thanks,
> 
> Jonathan
> 
> >   
>