linux-kernel - Re: [PATCH v4 19/23] ata: ahci: Add DWC AHCI SATA controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220615213029.3upsmasnnhigqozm@mobilestation>
Date:   Thu, 16 Jun 2022 00:30:29 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Jens Axboe <axboe@...nel.dk>, Hannes Reinecke <hare@...e.de>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Rob Herring <robh+dt@...nel.org>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 19/23] ata: ahci: Add DWC AHCI SATA controller support

On Fri, Jun 10, 2022 at 04:34:13PM -0700, Randy Dunlap wrote:
> Hi Serge,
> 
> On 6/10/22 14:58, Serge Semin wrote:
> > On Fri, Jun 10, 2022 at 09:34:46AM -0700, Randy Dunlap wrote:
> >> Hi--
> > 
> > Hi Randy
> > 
> >>
> >> On 6/10/22 01:17, Serge Semin wrote:
> >>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> >>> index bb45a9c00514..95e0e022b5bb 100644
> >>> --- a/drivers/ata/Kconfig
> >>> +++ b/drivers/ata/Kconfig
> >>> @@ -176,6 +176,16 @@ config AHCI_DM816
> >>>  
> >>>  	  If unsure, say N.
> >>>  
> >>> +config AHCI_DWC
> >>> +	tristate "Synopsys DWC AHCI SATA support"
> >>> +	select SATA_HOST
> >>> +	default SATA_AHCI_PLATFORM
> >>
> > 
> >> I don't think this needs to default to SATA_AHCI_PLATFORM.
> >> It might build a driver that isn't needed.
> >> And it's incompatible with "If unsure, say N."
> > 
> > Basically you are right, but this particular setting is connected with
> > the modification I've done in the drivers/ata/ahci_platform.c driver
> > in the framework of this commit. I've moved the "snps,spear-ahci" and
> > "snps,dwc-ahci" compatible devices support to the new driver. Thus
> > should I omit the SATA_AHCI_PLATFORM dependency their default kernel
> > configs will lack the corresponding controllers support. If it's not a
> > problem and we can rely on the kernel build system ability to ask
> > whether the new config needs to be set/cleared, then I would be very
> > happy to drop the default setting. What do you think?
> 

> I'd prefer to try it like that.
> If it becomes a problem, we can go back to this v4 patch.

Agreed then (seeing Damien is silent about your comment).

-Sergey

> 
> >>> +	help
> >>> +	  This option enables support for the Synopsys DWC AHCI SATA
> >>> +	  controller implementation.
> >>> +
> >>> +	  If unsure, say N.
> >>
> >> -- 
> >> ~Randy
> 
> Thanks.
> -- 
> ~Randy