linux-kernel - Re: [PATCH] audit: free module name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhT2nwdhhQg4Ak8sKV5YSAhRP=0XECyOkPE0=bAdKPvnhQ@mail.gmail.com>
Date:   Wed, 15 Jun 2022 19:33:35 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Christian Göttsche <cgzones@...glemail.com>
Cc:     Eric Paris <eparis@...hat.com>,
        Richard Guy Briggs <rgb@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: free module name

On Wed, Jun 15, 2022 at 11:44 AM Christian Göttsche
<cgzones@...glemail.com> wrote:
>
> Reset the type of the record last as the helper `audit_free_module()`
> depends on it.
>
>     unreferenced object 0xffff888153b707f0 (size 16):
>       comm "modprobe", pid 1319, jiffies 4295110033 (age 1083.016s)
>       hex dump (first 16 bytes):
>         62 69 6e 66 6d 74 5f 6d 69 73 63 00 6b 6b 6b a5  binfmt_misc.kkk.
>       backtrace:
>         [<ffffffffa07dbf9b>] kstrdup+0x2b/0x50
>         [<ffffffffa04b0a9d>] __audit_log_kern_module+0x4d/0xf0
>         [<ffffffffa03b6664>] load_module+0x9d4/0x2e10
>         [<ffffffffa03b8f44>] __do_sys_finit_module+0x114/0x1b0
>         [<ffffffffa1f47124>] do_syscall_64+0x34/0x80
>         [<ffffffffa200007e>] entry_SYSCALL_64_after_hwframe+0x46/0xb0
>
> Fixes: 12c5e81d3fd0 ("audit: prepare audit_context for use in calling contexts beyond syscalls")
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
>  kernel/auditsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Christian, I just merged this into audit/stable-5.19 and I'll
send this up to Linus as soon as the automated tests finish their
runs.

-- 
paul-moore.com