linux-kernel - 回复: [PATCH 1/2] powerpc:mm: export symbol ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 04:37:39 +0000
From:   Wenhu Wang <wenhu.wang@...mail.com>
To:     Michael Ellerman <mpe@...erman.id.au>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent

>发件人: Michael Ellerman <mpe@...erman.id.au>
>发送时间: 2022年6月14日 18:45
>收件人: Wang Wenhu <wenhu.wang@...mail.com>; gregkh@...uxfoundation.org <gregkh@...uxfoundation.org>; christophe.leroy@...roup.eu <christophe.leroy@...roup.eu>
>抄送: linuxppc-dev@...ts.ozlabs.org <linuxppc-dev@...ts.ozlabs.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; Wang Wenhu <wenhu.wang@...mail.com>
>主题: Re: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent 
> 
>Wang Wenhu <wenhu.wang@...mail.com> writes:
>> The function ioremap_coherent may be called by modules such as
>> fsl_85xx_cache_sram. So export it for access in other modules.
>
>ioremap_coherent() is powerpc specific, and only has one other caller,
>I'd like to remove it.
>
>Does ioremap_cache() work for you?
>

Yes, it works. I will update in v2 to use ioremap_cache.
I tested and compared the outcomes of ioremap_cache and ioremap_coherent,
and found they ended same values.

Thanks,
Wenhu

>
>> diff --git a/arch/powerpc/mm/ioremap.c b/arch/powerpc/mm/ioremap.c
>> index 4f12504fb405..08a00dacef0b 100644
>> --- a/arch/powerpc/mm/ioremap.c
>> +++ b/arch/powerpc/mm/ioremap.c
>> @@ -40,6 +40,7 @@ void __iomem *ioremap_coherent(phys_addr_t addr, unsigned long size)
>>                return iowa_ioremap(addr, size, prot, caller);
>>        return __ioremap_caller(addr, size, prot, caller);
>>  }
>> +EXPORT_SYMBOL(ioremap_coherent);
>>  
>>  void __iomem *ioremap_prot(phys_addr_t addr, unsigned long size, unsigned long flags)
>  {
> -- 
> 2.25.1