linux-kernel - [PATCH] x86,iommu:cleanup misleading comment about SWIOTLB turned off by IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 17:06:39 +0800
From:   korantwork@...il.com
To:     dave.hansen@...ux.intel.com, tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        trivial@...nel.org, Xinghui Li <korantli@...cent.com>
Subject: [PATCH] x86,iommu:cleanup misleading comment about SWIOTLB turned off by IOMMU

From: Xinghui Li <korantli@...cent.com>

According to commit 327d5b2fee91 ("iommu/vt-d: Allow 32bit devices to
uses DMA domain"), SWIOTLB could be enable even IOMMU exist.This comment
could mislead developer that there is an error enabling SWIOTLB when
they enable IOMMU.

Signed-off-by: Xinghui Li <korantli@...cent.com>
---
 arch/x86/kernel/pci-dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 30bbe4abb5d6..c0434abf7e09 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -193,7 +193,6 @@ static int __init pci_iommu_init(void)
 	x86_init.iommu.iommu_init();
 
 #ifdef CONFIG_SWIOTLB
-	/* An IOMMU turned us off. */
 	if (x86_swiotlb_enable) {
 		pr_info("PCI-DMA: Using software bounce buffering for IO (SWIOTLB)\n");
 		swiotlb_print_info();
-- 
2.25.1