linux-kernel - [PATCH] arch: arm: mach-ux500: Add missing of_node_put() in pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 17:40:31 +0800
From:   heliang <windhl@....com>
To:     linus.walleij@...aro.org, linux@...linux.org.uk
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        windhl@....com
Subject: [PATCH] arch: arm: mach-ux500: Add missing of_node_put() in pm_domain.c

In ux500_pm_domains_init(), of_find_matching_node() will return a
node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.

Signed-off-by: heliang <windhl@....com>
---
 arch/arm/mach-ux500/pm_domains.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c
index 427b9ac4af6c..80152e195fdd 100644
--- a/arch/arm/mach-ux500/pm_domains.c
+++ b/arch/arm/mach-ux500/pm_domains.c
@@ -66,8 +66,10 @@ int __init ux500_pm_domains_init(void)
 
 	genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL);
 	if (!genpd_data)
+	{
+		of_node_put(np);
 		return -ENOMEM;
-
+	}
 	genpd_data->domains = ux500_pm_domains;
 	genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);
 
@@ -75,5 +77,6 @@ int __init ux500_pm_domains_init(void)
 		pm_genpd_init(ux500_pm_domains[i], NULL, false);
 
 	of_genpd_add_provider_onecell(np, genpd_data);
+	of_node_put(np);
 	return 0;
 }
-- 
2.25.1