linux-kernel - Re: [PATCH] drivers: cpufreq: Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220615095237.6eefqhab4p2bbftt@vireshk-i7>
Date:   Wed, 15 Jun 2022 15:22:37 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     heliang <windhl@....com>
Cc:     rafael@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: cpufreq: Add missing of_node_put() in
 qoriq-cpufreq.c

On 15-06-22, 17:48, heliang wrote:
> In qoriq_cpufreq_probe(), of_find_matching_node() will return a
> node pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
> 
> Signed-off-by: heliang <windhl@....com>
> ---
>  drivers/cpufreq/qoriq-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c
> index 6b6b20da2bcf..573b417e1483 100644
> --- a/drivers/cpufreq/qoriq-cpufreq.c
> +++ b/drivers/cpufreq/qoriq-cpufreq.c
> @@ -275,6 +275,7 @@ static int qoriq_cpufreq_probe(struct platform_device *pdev)
>  
>  	np = of_find_matching_node(NULL, qoriq_cpufreq_blacklist);
>  	if (np) {
> +		of_node_put(np);
>  		dev_info(&pdev->dev, "Disabling due to erratum A-008083");
>  		return -ENODEV;
>  	}

Applied with fixes tag. Thanks.

-- 
viresh