linux-kernel - Re: [PATCH v5 4/5] arm64: mm: Only remove nomap flag for initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yqmukqq5E2FPz+/6@arm.com>
Date:   Wed, 15 Jun 2022 11:04:02 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Wupeng Ma <mawupeng1@...wei.com>
Cc:     corbet@....net, will@...nel.org, ardb@...nel.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        dvhart@...radead.org, andy@...radead.org, rppt@...nel.org,
        akpm@...ux-foundation.org, paul.walmsley@...ive.com,
        palmer@...belt.com, aou@...s.berkeley.edu, paulmck@...nel.org,
        keescook@...omium.org, songmuchun@...edance.com,
        rdunlap@...radead.org, damien.lemoal@...nsource.wdc.com,
        swboyd@...omium.org, wei.liu@...nel.org, robin.murphy@....com,
        david@...hat.com, anshuman.khandual@....com,
        thunder.leizhen@...wei.com, wangkefeng.wang@...wei.com,
        gpiccoli@...lia.com, chenhuacai@...nel.org, geert@...ux-m68k.org,
        vijayb@...ux.microsoft.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-efi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-mm@...ck.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v5 4/5] arm64: mm: Only remove nomap flag for initrd

On Tue, Jun 14, 2022 at 05:21:55PM +0800, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@...wei.com>
> 
> Commit 177e15f0c144 ("arm64: add the initrd region to the linear mapping explicitly")
> remove all the flags of the memory used by initrd. This is fine since
> MEMBLOCK_MIRROR is not used in arm64.
> 
> However with mirrored feature introduced to arm64, this will clear the mirrored
> flag used by initrd, which will lead to error log printed by
> find_zone_movable_pfns_for_nodes() if the lower 4G range has some non-mirrored
> memory.
> 
> To solve this problem, only MEMBLOCK_NOMAP flag will be removed via
> memblock_clear_nomap().
> 
> Signed-off-by: Ma Wupeng <mawupeng1@...wei.com>
> Reviewed-by: Ard Biesheuvel <ardb@...nel.org>

Acked-by: Catalin Marinas <catalin.marinas@....com>