linux-kernel - Re: [PATCH v4 4/4] PM / devfreq: Mute warning on governor PROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 11:22:41 +0200
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     Chanwoo Choi <cwchoi00@...il.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Sibi Sankar <sibis@...eaurora.org>,
        Saravana Kannan <skannan@...eaurora.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/4] PM / devfreq: Mute warning on governor PROBE_DEFER

On Wed, Jun 15, 2022 at 03:56:31PM +0900, Chanwoo Choi wrote:
> On 22. 6. 15. 08:09, Christian 'Ansuel' Marangi wrote:
> > Don't print warning when a governor PROBE_DEFER as it's not a real
> > GOV_START fail.
> > 
> > Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
> > Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@...il.com>
> > ---
> >  drivers/devfreq/devfreq.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index 2e2b3b414d67..6a39638ed064 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -931,8 +931,9 @@ struct devfreq *devfreq_add_device(struct device *dev,
> >  	err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
> >  						NULL);
> >  	if (err) {
> > -		dev_err(dev, "%s: Unable to start governor for the device\n",
> > -			__func__);
> > +		dev_err_probe(dev, err,
> > +			      "%s: Unable to start governor for the device\n",
> > +			      __func__);
> >  		goto err_init;
> >  	}
> >  	create_sysfs_files(devfreq, devfreq->governor);
> 
> 
> In order to keep the left-align with above error log
> when try_then_request_governor() is failed,
> I recommend to use the tab without space indentation as following:
> 
> If you have no objection, I'll merge this change.
> 

Sure, good for me. Anyway I wonder if we can relax the hard limit for 80
for error print since we now can use 100, but your choice.

> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 01474daf4548..80a1235ef8fb 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -932,8 +932,9 @@ struct devfreq *devfreq_add_device(struct device *dev,
>         err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>                                                 NULL);
>         if (err) {
> -               dev_err(dev, "%s: Unable to start governor for the device\n",
> -                       __func__);
> +               dev_err_probe(dev, err,
> +                       "%s: Unable to start governor for the device\n",
> +                        __func__);
>                 goto err_init;
>         }
>         create_sysfs_files(devfreq, devfreq->governor);
> 
> 
> 
> 
> 
> -- 
> Best Regards,
> Samsung Electronics
> Chanwoo Choi

-- 
	Ansuel