[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YqnDNL/ComIpYYe1@fedora>
Date: Wed, 15 Jun 2022 07:32:04 -0400
From: William Breathitt Gray <william.gray@...aro.org>
To: Zhi Song <zhi.song@...edance.com>
Cc: gregkh@...uxfoundation.org, rafael@...nel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] isa: put_device after failing to device_register
On Wed, Jun 15, 2022 at 12:47:10AM +0800, Zhi Song wrote:
> device_register() is used to register a device with the system.
> We need to call put_device() to give up the reference initialized
> in device_register() when it returns an error and this will clean
> up correctly.
>
> Signed-off-by: Zhi Song <zhi.song@...edance.com>
Hi Zhi,
Would you add a Fixes tag line specifying the commit where this bug was
introduced. That will help us get this fix into previous kernel versions
as well.
Thanks,
William Breathitt Gray
> ---
> V1 -> V2: Fix up the changelog text correct.
> ---
> drivers/base/isa.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/isa.c b/drivers/base/isa.c
> index 55e3ee2da98f..cf88f3d77b7d 100644
> --- a/drivers/base/isa.c
> +++ b/drivers/base/isa.c
> @@ -173,8 +173,10 @@ static int __init isa_bus_init(void)
> error = bus_register(&isa_bus_type);
> if (!error) {
> error = device_register(&isa_bus);
> - if (error)
> + if (error) {
> + put_device(&isa_bus);
> bus_unregister(&isa_bus_type);
> + }
> }
> return error;
> }
> --
> 2.30.2
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists