linux-kernel - Re: [PATCH] spi: microchip-core: fix passing zero to PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqnFLCbvrTxNbG1+@sirena.org.uk>
Date:   Wed, 15 Jun 2022 12:40:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     Daire McNamara <daire.mcnamara@...rochip.com>,
        Lewis Hanly <lewis.hanly@...rochip.com>,
        linux-riscv@...ts.infradead.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] spi: microchip-core: fix passing zero to PTR_ERR warning

On Wed, Jun 15, 2022 at 12:30:22PM +0100, Conor Dooley wrote:

> -		ret = PTR_ERR(spi->clk);
> +		ret = !spi->clk ? -ENXIO : PTR_ERR(spi->clk);

I think you're looking for PTR_ERR_OR_ZERO() here?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)