linux-kernel - Re: [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a6e1547-cdcb-81ae-79fd-b0e56fca2f76@roeck-us.net>
Date:   Wed, 15 Jun 2022 04:57:49 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eugene Shalygin <eugene.shalygin@...il.com>
Cc:     Michael Carns <mike@...ns.com>, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name
 list.

On 6/15/22 03:45, Eugene Shalygin wrote:
> From: Michael Carns <mike@...ns.com>
> 
> This fixes a regression introduced by commit 5b4285c57b6f
> ("hwmon: (asus-ec-sensors) fix Formula VIII definition")
> where coma lead to concatenating board names and broke module
> loading for C8H.
> 
> Signed-off-by: Michael Carns <mike@...ns.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@...il.com>

We have a Fixes: tag for such purposes. Please use it.

Thanks,
Guenter

> ---
>   drivers/hwmon/asus-ec-sensors.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 886a71b4c64e..19d3ca71b360 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
>   	},
>   	{
>   		.board_names = {
> -			"ROG CROSSHAIR VIII FORMULA"
> +			"ROG CROSSHAIR VIII FORMULA",
>   			"ROG CROSSHAIR VIII HERO",
>   			"ROG CROSSHAIR VIII HERO (WI-FI)",
>   		},