linux-kernel - Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 08:19:30 -0400
From:   William Breathitt Gray <william.gray@...aro.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register
 structures

On Wed, Jun 15, 2022 at 02:00:26PM +0200, Andy Shevchenko wrote:
> On Wed, Jun 15, 2022 at 1:55 PM William Breathitt Gray
> <william.gray@...aro.org> wrote:
> > On Wed, Jun 15, 2022 at 11:44:54AM +0200, Andy Shevchenko wrote:
> > > On Mon, Jun 6, 2022 at 4:27 PM William Breathitt Gray
> > > <william.gray@...aro.org> wrote:
> > > >
> > > > Reduce magic numbers and improve code readability by implementing and
> > > > utilizing named register data structures.
> > >
> > > Can we consider using regmap APIs instead?
> 
> > The regmap API may be more appropriate here. I'll investigate and see if
> > I can convert this over to it.
> 
> I just realized that this driver is for the old PC104 (like?) hardware
> that most likely uses IO ports, I don't remember if we have support
> for IO ports in regmap (MMIO -- yes for sure).
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Hmm, I don't see IO ports mentioned in include/linux/regmap.h, so I
don't think the regmap API directly supports it (maybe someone familiar
with regmap knows). Although we do get a virtual mapping cookie via
ioport_map() in this driver, I don't know if we can pass that to the
regmap functions and have it actually work.

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)