linux-kernel - Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220615132841.GC1429@bug>
Date:   Wed, 15 Jun 2022 15:28:41 +0200
From:   Pavel Machek <pavel@....cz>
To:     David Wang <David_Wang6097@...il.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        edward_chen@...il.com, ben_pai@...il.com
Subject: Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC

Hi!

> The initial introduction of the jabil server with AST2600 BMC SoC.


> +		led-0 {
> +			label = "identify";
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_INDICATOR;
> +			retain-state-shutdown;
> +			gpios = <&gpio0 ASPEED_GPIO(B, 7) GPIO_ACTIVE_LOW>;
> +		};
> +
> +		led-1 {
> +			label = "status_amber";
> +			label = "status_green";
> +			label = "status_susack";
> +		led-4 {
> +			label = "power-amber";
> +			label = "fan1-fault";

Please take a look at LED documentation and try to come up with something more in line
with existing conventions. Also please cc linux-leds list.

Best regards,
										Pavel