linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220615132809.GA1429@bug>
Date:   Wed, 15 Jun 2022 15:28:09 +0200
From:   Pavel Machek <pavel@....cz>
To:     Tom Fitzhenry <tom@...-fitzhenry.me.uk>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Samuel Holland <samuel@...lland.org>, Ondrej Jirman <x@....cz>,
        Martijn Braam <martijn@...xit.nl>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro
 bindings

Hi!

> Document board compatible names for Pine64 PinePhonePro.
> 
> https://wiki.pine64.org/wiki/PinePhone_Pro
> 
> Signed-off-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>

It makes sense to get this reviewed early, because Rob's ack is needed here, right?

> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -489,6 +489,11 @@ properties:
>            - const: pine64,pinenote
>            - const: rockchip,rk3566
>  
> +      - description: Pine64 PinePhonePro
> +        items:
> +          - const: pine64-pinephone-pro

This should be pine64,... right?

Best regards,
									Pavel


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html