[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_Jsq+3oS=SB-TVH3JA7Jb8KDgQ8ek_KPJSQhL0mgiq4sjmyQ@mail.gmail.com>
Date: Wed, 15 Jun 2022 07:33:36 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Piyush Mehta <piyush.mehta@...inx.com>
Cc: Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@...r.kernel.org>, devicetree@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Michal Simek <michal.simek@...inx.com>, git <git@...inx.com>,
Siva Durga Prasad Paladugu <sivadur@...inx.com>
Subject: Re: [PATCH V4] dt-bindings: ata: ahci-ceva: convert to yaml
On Wed, Jun 15, 2022 at 1:14 AM Piyush Mehta <piyush.mehta@...inx.com> wrote:
>
> Convert the ahci-ceva doc to yaml.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@...inx.com>
> ---
> Changes for V2:
> - Corrected the patch --prefix V3 to V2.
> - Added Required properties.
>
> Changes for V3:
> - Skip patch --prefix [PATCH V3] as already sent.
>
> Changes for V4:
> - Addressed Rob review comments:-
> - Update params description
> - Removed description from common properties.
> - Deleted deprecated property.
> - Warning generated from: 'make dtbs_check'
> - Thanks Rob: We are aware of these warnings,
> but they are unrelated to this patch.
Huh? You are saying the dts files are wrong and should not have
'iommus' or 'phy-names' properties? That doesn't seem likely for
'iommus'. If the old binding was wrong, it is fine to add the
properties in the conversion. Just note that in the commit message.
> ---
> .../devicetree/bindings/ata/ahci-ceva.txt | 63 ------
> .../devicetree/bindings/ata/ahci-ceva.yaml | 182 ++++++++++++++++++
> 2 files changed, 182 insertions(+), 63 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/ahci-ceva.txt
> create mode 100644 Documentation/devicetree/bindings/ata/ahci-ceva.yaml
Also, rename to ceva,ahci-1v84.yaml for the filename.
Rob
Powered by blists - more mailing lists